Remove unused pipeline process stage - #26
Merged
Merged
Conversation
bomly-guy
changed the title
bomly-guy
marked this pull request as ready for review
May 8, 2026 09:11
bomly-guy
added a commit
that referenced
this pull request
May 9, 2026
Resolves four conflicts after main absorbed: - internal/scan -> internal/engine package rename - removal of the unused pipeline 'process' stage (#26) - Go 1.26 toolchain bump and golangci-lint v2 Resolutions: - pipeline.go / types.go: keep the analyze stage; drop Processor and StageProcessor since main removed the process stage. Update the Pipeline doc comment to reflect the merged stage list: pre-resolve hooks -> detect -> scope filter -> consolidate -> match -> analyze -> audit -> post-resolve hooks - internal/cli/opts/filters.go: switch buildAnalyzerSelectorCatalog from selector.Catalog to the local catalog type used by the matcher / auditor selector helpers post-rename. - CLAUDE.md / docs/ARCHITECTURE.md: keep the reachability stage description; drop the obsolete commandProcess step. - pyreach: collapse two redundant if-return-true; return false patterns flagged by golangci-lint v2 staticcheck S1008. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StageProcessor/PipelineRequest.Processorcallback surface.Why
The process stage had no production callers; it was only exercised by its own unit test. Keeping it in the pipeline made the documented flow look more extensible than the implementation actually needed.
Validation
make testNote: the commit hook was bypassed because unrelated unstaged selector/opts changes in the working tree caused the hook's gofmt file list to reference paths that were intentionally excluded from this PR.