Skip to content

[scan] Partial Autograd support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bohnstingl wants to merge 12 commits into
base: scan_autograd2
Choose a base branch
from
Open

[scan] Partial Autograd support #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
86ea4fc
WIP: wrapper function to allow partial gradients
bohnstingl Sep 17, 2024
a4a5f75
Working version of partial additional_input gradients
bohnstingl Sep 20, 2024
ee3e134
Working version of partial xs
bohnstingl Sep 20, 2024
f6bdfe7
Partial init autograd working
bohnstingl Sep 21, 2024
3ffbbad
with torch.no_grad() working
bohnstingl Sep 21, 2024
f36237f
Working version of partial gradients
bohnstingl Sep 21, 2024
fdc5ce4
Working version of partial gradients
bohnstingl Sep 21, 2024
a510020
Minor simplification
bohnstingl Sep 22, 2024
01ca2cf
Pre-cleanup
bohnstingl Oct 9, 2024
59ce6dd
After clean-up
bohnstingl Oct 9, 2024
418b323
Fixed issue with output aliasing of joint_graph
bohnstingl Oct 11, 2024
ddbdb66
*) Combined input alias check with output alias check
bohnstingl Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
523 changes: 397 additions & 126 deletions test/functorch/test_control_flow.py
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion torch/_dynamo/trace_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2284,7 +2284,7 @@
"torch._guards.compile_context",
"torch._guards.detect_fake_mode",
"torch._guards.tracing",
"torch._higher_order_ops.map._has_potential_branch_input_alias",
"torch._higher_order_ops.map._has_potential_branch_input_output_alias",
"torch._higher_order_ops.map._has_potential_branch_input_mutation",
"torch._higher_order_ops.map._stack_pytree",
"torch._higher_order_ops.map._unstack_pytree",
Expand Down
4 changes: 2 additions & 2 deletions torch/_higher_order_ops/cond.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
from torch._functorch.utils import exposed_in
from torch._guards import detect_fake_mode
from torch._higher_order_ops.utils import (
_has_potential_branch_input_alias,
_has_potential_branch_input_mutation,
_has_potential_branch_input_output_alias,
_maybe_run_with_interpreter,
_set_compilation_env,
reenter_make_fx,
Expand Down Expand Up @@ -469,7 +469,7 @@ def cond_func(ctx, pred, true_fn, false_fn, inputs):
"One of torch.cond branch might be modifying the input!"
)
for branch in [true_fn, false_fn]:
if _has_potential_branch_input_alias(
if _has_potential_branch_input_output_alias(
branch, unwrapped_inputs, pre_dispatch=pre_dispatch
):
raise UnsupportedAliasMutationException(
Expand Down
4 changes: 2 additions & 2 deletions torch/_higher_order_ops/hints_wrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import torch.utils._pytree as pytree
from torch._C import DispatchKey
from torch._higher_order_ops.utils import (
_has_potential_branch_input_alias,
_has_potential_branch_input_mutation,
_has_potential_branch_input_output_alias,
autograd_not_implemented,
reenter_make_fx,
unique_graph_id,
Expand Down Expand Up @@ -103,7 +103,7 @@ def hints_wrapper_functionalize(ctx, body_fn, args, kwargs, hints):
raise UnsupportedAliasMutationException(
"body_fn of hints_wrapper might be modifying the input!"
)
if _has_potential_branch_input_alias(
if _has_potential_branch_input_output_alias(
functional_body_fn, unwrapped_args, pre_dispatch=pre_dispatch
):
raise UnsupportedAliasMutationException(
Expand Down
4 changes: 2 additions & 2 deletions torch/_higher_order_ops/map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
from torch._dispatch.python import suspend_functionalization
from torch._functorch.aot_autograd import AOTConfig, create_joint
from torch._higher_order_ops.utils import (
_has_potential_branch_input_alias,
_has_potential_branch_input_mutation,
_has_potential_branch_input_output_alias,
_maybe_run_with_interpreter,
reenter_make_fx,
UnsupportedAliasMutationException,
Expand Down Expand Up @@ -255,7 +255,7 @@ def map_functionalize(ctx, f, xs, pos_args):
):
raise UnsupportedAliasMutationException("torch.map is mutating the input!")

if _has_potential_branch_input_alias(
if _has_potential_branch_input_output_alias(
f, example_inputs, pre_dispatch=pre_dispatch
):
raise UnsupportedAliasMutationException("torch.map is aliasing the input!")
Expand Down
Loading