Conversation
bodgit
commented
Jul 10, 2026
bodgit
commented
Owner
- fix: return EOF when buffer is empty
- test: add test case for read loop
- test: Tweak test case
The bra reader could return invalid results when a read ended exactly so no data was left: In this case, the rc.rc read returned (0, EOF), rc.n was 0. Therefore the rc.buf.Read() was called with an empty slice, which caused it to return (0, nil), which was then returned to the caller, and left the reader in the same state as before. In combination with e.g. io.ReadAll, this could cause an endless loop.
* Rename the test and example archive to make it slightly more obvious which filter is tested and tie it to the GitHub PR number. * Wrap the test with a timeout so without the fix the test times out quickly rather than just spinning until the overall test timeout triggers.
|
coverage: 75.362% (+0.2%) from 75.131% — bra-eof into main |
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.