Add CI pipeline

.github/workflows/ci.yml

@@ -0,0 +1,80 @@
+name: CI
+
+on:
+  pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.11'
+      - uses: pre-commit/action@v3.0.1
+
+  integration:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y zsh vim tmux
+      - name: Setup environment
+        run: |
+          mkdir -p ~/src/bobwhitelock
+          ln -s ${{ github.workspace }} ~/src/bobwhitelock/dotfiles
+      - name: Run install script
+        run: |
+          set -x
+          cd ~/src/bobwhitelock/dotfiles
+          ./install
+          echo "Install script completed successfully"
+      - name: Verify zsh loads without errors
+        run: |
+          set -x
+          echo "=== Testing zsh lib files individually ==="
+          export DOTFILES="$HOME/src/bobwhitelock/dotfiles"
+          export ZSH_DIR="$DOTFILES/zsh"
+          export ZSH_LIB="$ZSH_DIR/lib"
+
+          # First test env.sh alone
+          echo "Testing env.sh..."
+          output=$(zsh -c "source '$ZSH_DIR/env.sh'" 2>&1) || true
+          if [ -n "$output" ]; then
+            echo "env.sh produced output: $output"
+          fi
+
+          # Test each lib file
+          for f in "$ZSH_LIB"/*; do
+            fname=$(basename "$f")
+            output=$(zsh -c "
+              source '$ZSH_DIR/env.sh'
+              source '$f'
+            " 2>&1) || true
+            if [ -n "$output" ]; then
+              echo "ERROR: $fname produced output:"
+              echo "$output"
+            else
+              echo "OK: $fname"
+            fi
+          done
+
+          echo "=== Full zsh load test ==="
+          output=$(zsh -c '
+            export DOTFILES="$HOME/src/bobwhitelock/dotfiles"
+            export ZSH_DIR="$DOTFILES/zsh"
+            export ZSH_LIB="$ZSH_DIR/lib"
+            source "$ZSH_DIR/env.sh"
+            for f in "$ZSH_LIB"/*; do
+              source "$f"
+            done
+          ' 2>&1) || true
+
+          if [ -n "$output" ]; then
+            echo "ERROR: zsh produced unexpected output:"
+            echo "$output"
+            exit 1
+          fi
+          echo "zsh loaded successfully with no output"

.pre-commit-config.yaml

@@ -0,0 +1,50 @@
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: check-merge-conflict
+      - id: check-added-large-files
+      - id: check-executables-have-shebangs
+
+  - repo: https://github.com/crate-ci/typos
+    rev: v1.28.4
+    hooks:
+      - id: typos
+
+  - repo: https://github.com/koalaman/shellcheck-precommit
+    rev: v0.10.0
+    hooks:
+      - id: shellcheck
+        args: ["-x"]  # follow source statements
+        files: \.(sh|bash)$|^bin/|^libexec/
+        exclude: \.(py|pl)$|colours-to-rgb|extract_urls|git-ls-revisions|stripcolours|todoist-to-markdown|env\.private\.example\.sh
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.8.6
+    hooks:
+      - id: ruff
+        args: [--fix]
+      - id: ruff-format
+
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.14.1
+    hooks:
+      - id: mypy
+        additional_dependencies: []
+
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.35.1
+    hooks:
+      - id: yamllint
+        args: [-c, .yamllint.yml]
+
+  - repo: local
+    hooks:
+      - id: vint
+        name: vint
+        entry: vint
+        language: python
+        additional_dependencies: [vim-vint]
+        files: \.vim$|vimrc$|gvimrc$

.typos.toml

@@ -0,0 +1,7 @@
+[default.extend-words]
+# Vim mapping <leader>ue for UltiSnipsEdit
+ue = "ue"
+# Project name, not underwear
+underware = "underware"
+# Alias for git rebase --abort
+grea = "grea"

.yamllint.yml

@@ -0,0 +1,20 @@
+extends: default
+
+# tmuxinator files use ERB templating which makes them invalid YAML
+ignore:
+  - tmuxinator/
+
+rules:
+  line-length:
+    max: 150
+  truthy:
+    check-keys: false
+  document-start: disable
+  comments:
+    min-spaces-from-content: 1
+  empty-lines:
+    max-start: 1
+  indentation:
+    indent-sequences: whatever
+  comments-indentation: disable
+  key-duplicates: disable

Taskfile.yml

@@ -0,0 +1,42 @@
+version: '3'
+
+tasks:
+  dev:
+    desc: Install development dependencies
+    cmds:
+      - pipx install pre-commit vint
+
+  # TODO BW 2026-01-26: Add install and other scripts in here instead? Though
+  # then need `task` installed first.
+
+  lint:
+    desc: Run all linters
+    cmds:
+      - pre-commit run --all-files
+
+  integration:
+    desc: Run install script and verify zsh loads cleanly
+    cmds:
+      - ./install
+      - |
+        output=$(zsh -c '
+          export DOTFILES="$HOME/src/bobwhitelock/dotfiles"
+          export ZSH_DIR="$DOTFILES/zsh"
+          export ZSH_LIB="$ZSH_DIR/lib"
+          source "$ZSH_DIR/env.sh"
+          for f in "$ZSH_LIB"/*; do
+            source "$f"
+          done
+        ' 2>&1) || true
+        if [ -n "$output" ]; then
+          echo "ERROR: zsh produced unexpected output:"
+          echo "$output"
+          exit 1
+        fi
+        echo "zsh loaded successfully with no output"
+
+  ci:
+    desc: Full CI pipeline
+    cmds:
+      - task: lint
+      - task: integration

aider.conf.yml

@@ -6,7 +6,9 @@
 #
 # Can also run
 # ```
-# yaml_to_json /home/bob/src/Aider-AI/aider/aider/website/_data/polyglot_leaderboard.yml | jq '[.[] | select(.seconds_per_case < 30 and (.command | contains("openrouter") | not))] | sort_by(.pass_rate_2)'
+# yaml_to_json .../polyglot_leaderboard.yml | \
+#   jq '[.[] | select(.seconds_per_case < 30 and
+#       (.command | contains("openrouter") | not))] | sort_by(.pass_rate_2)'
 # ```
 # to see models I might be able to use, that are not too slow, by speed at
 # Aider benchmark (but also take with a pinch of salt - a lot of people think

bin/add_window

@@ -11,7 +11,7 @@ IFS=$'\n\t'
 main() {
     local tmux_command
 
-    # shellcheck disable=SC1090
+    # shellcheck disable=SC1090,SC1091
     source "$ZSH_LIB/tmux.sh"
 
     if [ -n "$TMUX" ]; then

bin/clone

@@ -40,7 +40,7 @@ main() {
         gh repo clone "$repo"
     fi
 
-    # shellcheck disable=SC1090
+    # shellcheck disable=SC1090,SC1091
     source "$ZSH_LIB/tmux.sh"
     add_window --vim-pane "$name"
 }

bin/colours-to-rgb

@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
 import sys
+
 import webcolors
 
 # Convert hex or named CSS3 colours on stdin to rgb values on stdout.
@@ -15,5 +16,6 @@ def main():
 
         print(colour, *rgb)
 
+
 if __name__ == "__main__":
     main()

bin/extract_urls

@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 
-import sys
 import re
+import sys
 
 # Extract URLs from a file given as the first argument, or stdin, and output
 # one URL per line.
@@ -11,7 +11,7 @@ URL_PATTERN = r'https?://[^\s<>"{}|\\^`\[\]()]+'
 
 def main():
     if len(sys.argv) > 1:
-        with open(sys.argv[1], "r") as f:
+        with open(sys.argv[1]) as f:
             extract_urls_from_lines(f)
     else:
         extract_urls_from_lines(sys.stdin)

bin/git-about

@@ -4,6 +4,7 @@ IFS=$'\n\t'
 
 
 main() {
+   # shellcheck disable=SC2198 # Auto-suppressed when enabling Shellcheck.
    if [ ! -e "$@" ]; then
       echo "Error: Path does not exist: $*"
       exit 1

bin/git-ls-revisions

@@ -3,7 +3,6 @@
 import operator
 import subprocess
 
-
 # Lists all tracked files in repo along with the number of commits which have
 # changed them, in order from most to least.
 
@@ -13,34 +12,26 @@ import subprocess
 
 
 def main():
-    tracked_files = output_lines(
-        ['git', 'ls-tree', '--full-tree', '--name-only', '-r', 'HEAD']
-    )
+    tracked_files = output_lines(["git", "ls-tree", "--full-tree", "--name-only", "-r", "HEAD"])
 
     file_to_revisions = {}
     for file in tracked_files:
         try:
-            revisions = output_lines(
-                ['git', 'log', '--oneline', '--follow', file]
-            )
+            revisions = output_lines(["git", "log", "--oneline", "--follow", file])
             file_to_revisions[file] = len(revisions)
         except subprocess.CalledProcessError as ex:
             print(ex)
 
-    sorted_files = sorted(
-        file_to_revisions.items(),
-        key=operator.itemgetter(1),
-        reverse=True
-    )
+    sorted_files = sorted(file_to_revisions.items(), key=operator.itemgetter(1), reverse=True)
 
     for file, revision_count in sorted_files:
-        print('{} - {}'.format(file, revision_count))
+        print(f"{file} - {revision_count}")
 
 
 def output_lines(command):
     output = subprocess.check_output(command, universal_newlines=True)
-    return [line for line in output.split('\n') if len(line) > 0]
+    return [line for line in output.split("\n") if len(line) > 0]
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()

bin/git-sync-branches

@@ -25,4 +25,3 @@ _sync_branch() {
 
 
 main "$@"
-

bin/git-wip

@@ -5,6 +5,7 @@ IFS=$'\n\t'
 
 main() {
     local message
+    # shellcheck disable=SC2124 # Auto-suppressed when enabling Shellcheck.
     message="WIP $@"
     git commit --no-verify -m "$message"
 }

bin/mv_notes

@@ -44,7 +44,8 @@ update_wikilinks() {
         fi
 
         # Create a temporary file for the updates
-        local temp_file=$(mktemp)
+        local temp_file
+        temp_file=$(mktemp)
 
         # Update wikilinks that reference the old path
         # This handles cases like:

bin/replace_window

@@ -9,7 +9,7 @@ IFS=$'\n\t'
 main() {
     local current_window new_window
 
-    # shellcheck disable=SC1090
+    # shellcheck disable=SC1090,SC1091
     source "$ZSH_LIB/tmux.sh"
 
     # shellcheck disable=SC2063

bin/rofr.sh

@@ -23,7 +23,7 @@ usage()
 
      -b,--browser       Browser search by keyword (requires surfraw)
 
-     -q,--qalculate     Persistant calculator dialog (requires libqalculate)
+     -q,--qalculate     Persistent calculator dialog (requires libqalculate)
 
      -c,--clipboard     Select previous clipboard entries (requires greenclip)
 
@@ -79,7 +79,7 @@ for arg in "$@"; do
                 -padding 50 -line-padding 4)"
             ;;
         -l|--logout)
-            if grep -q 'exec startx' $HOME/.*profile; then
+            if grep -q 'exec startx' "$HOME"/.*profile; then
                 ANS="$(rofi -sep "|" -dmenu -i -p 'System' -width 20 \
                     -hide-scrollbar -line-padding 4 -padding 20 \
                     -lines 3 <<< " Lock| Reboot| Shutdown")"