fix: use snake_case inputs for actions/first-interaction@v3 - #346
Merged
Conversation
v3 renamed its inputs from kebab-case to snake_case (repo-token -> repo_token, issue-message -> issue_message, pr-message -> pr_message). The old names are silently ignored, leaving issue_message unset, which crashes the workflow on any real "opened" pull_request_target/issues event. Synchronize events happened to skip past the crash, which is why this went unnoticed after the v1->v3 bump in #292.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 59 59
Lines 2621 2621
Branches 136 136
=======================================
Hits 2610 2610
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#292 bumped `actions/first-interaction` from v1 to v3, but v3 renamed its inputs from kebab-case to snake_case (`repo-token` -> `repo_token`, `issue-message` -> `issue_message`, `pr-message` -> `pr_message`). The old kebab-case names are silently ignored (with an "Unexpected input(s)" warning), leaving the required `issue_message` unset. This crashes the Greetings workflow on any genuine `opened` pull_request_target/issues event.
Synchronize events (e.g. pushes to an existing PR branch) happen to skip past the crash, since the action checks the event action before validating required inputs — which is why this went unnoticed until a fresh PR/issue is actually opened.
What Changed
Renamed the three inputs to their v3 snake_case equivalents.
Verification
Confirmed the crash in CI logs on a real "opened" event (dependabot PR #345's initial run), and confirmed the same input-name mismatch by diffing against v3's schema.