Add configurable stage move limits - #1316
Open
janmarsino98 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973
Summary
maxMovessetStageandsetActivePlayersas higher-priority overridesmoveLimitspelling for compatibilityRoot cause
Stage configuration only exposed moves and the next stage. The flow initialized active-player limits exclusively from activation arguments, so it never consulted the stage being entered.
Tests
pnpm run lintpnpm test: 43 suites passed, 908 tests passed, 1 todo, 1 snapshotpnpm run test:coverage: 100% statements, branches and linespnpm run tspnpm run buildChecklist
main).