Skip to content

Add configurable stage move limits - #1316

Open
janmarsino98 wants to merge 1 commit into
boardgameio:mainfrom
janmarsino98:stage-move-limits-973
Open

Add configurable stage move limits#1316
janmarsino98 wants to merge 1 commit into
boardgameio:mainfrom
janmarsino98:stage-move-limits-973

Conversation

@janmarsino98

Copy link
Copy Markdown
Contributor

Fixes #973

Summary

  • allow stage definitions to provide a default maxMoves
  • keep explicit limits from setStage and setActivePlayers as higher-priority overrides
  • support the deprecated moveLimit spelling for compatibility
  • document stage-level limits and their precedence

Root cause

Stage configuration only exposed moves and the next stage. The flow initialized active-player limits exclusively from activation arguments, so it never consulted the stage being entered.

Tests

  • focused core suites: 197 tests passed
  • pnpm run lint
  • pnpm test: 43 suites passed, 908 tests passed, 1 todo, 1 snapshot
  • pnpm run test:coverage: 100% statements, branches and lines
  • pnpm run ts
  • pnpm run build

Checklist

  • Use a separate branch in your local repo (not main).
  • Test coverage is 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Stages should have their own move limit

1 participant