chore(deps-dev): remove tempy - #1313
Open
devill wants to merge 5 commits into
Open
Conversation
The script wrote the new notes to a temp file, appended the existing changelog to it, then copied the whole thing back. Concatenating in memory and writing once says the same thing in one line, and drops the only reason this script needed a temp-file library. Output is byte-identical.
Nothing imports it since the previous commit. This also closes #1303: tempy 3 is ESM-only with a top-level await, so `require('tempy')` throws ERR_REQUIRE_ASYNC_MODULE, and `file()` was renamed to `temporaryFile()`. Neither shows up in CI because nothing there runs the changelog script — it would have failed at the next release.
# Conflicts: # pnpm-lock.yaml
Rupesh-ark
approved these changes
Aug 16, 2026
Rupesh-ark
left a comment
Rupesh-ark
left a comment
Member
There was a problem hiding this comment.
Looks good. This keeps the changelog script CommonJS compatible and removes an unnecessary dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1303 by removing the dependency rather than upgrading it.
Why #1303 can't be merged. tempy 3 breaks
scripts/changelog.jstwice over: it is ESM-only with a top-level await, sorequire('tempy')throwsERR_REQUIRE_ASYNC_MODULE, andfile()was renamed totemporaryFile(). Neither shows up in CI, because nothing there runs the changelog script — it is invoked by hand afternpm version. The break would land at the next release.Why the dependency can go. tempy was used for exactly one thing: a scratch path to prepend the new release notes to
docs/documentation/CHANGELOG.md. The script wrote the notes to that temp file, appended the existing changelog to it, then copied the result back. Concatenating in memory and writing once does the same job in one line and needs no temp file at all.Verified by running
pnpm run changelogbefore and after the refactor and diffing the generatedCHANGELOG.md— byte-identical.pnpm test(43 suites / 901 tests) andpnpm run lintare green.