Skip to content

contracts: note that StakeCredit.slash() intentionally ignores the unbond queue #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zlacfzy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

contracts: note that StakeCredit.slash() intentionally ignores the unbond queue #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions contracts/StakeCredit.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ contract StakeCredit is SystemV2, Initializable, ReentrancyGuardUpgradeable, ERC
* @dev Slash the validator. Only the `StakeHub` contract can call this function.
* @param slashBnbAmount the amount of BNB to be slashed
* @return realSlashBnbAmount the real amount of BNB slashed
*
* @notice Slashing is intentionally limited to the validator's active self-delegation
* (`balanceOf(validator)`); amounts recorded in the unbonding queue are outside this
* burn. A zero burn is therefore a valid outcome and must not itself cause `slash()`
* to revert on consensus-driven slashing paths.
*/
function slash(
uint256 slashBnbAmount
Expand Down
Loading