Skip to content

docs: fix broken README link - #621

Open
Inna333-cuber wants to merge 5 commits into
bnb-chain:developfrom
Inna333-cuber:patch-1
Open

docs: fix broken README link#621
Inna333-cuber wants to merge 5 commits into
bnb-chain:developfrom
Inna333-cuber:patch-1

Conversation

@Inna333-cuber

Copy link
Copy Markdown

Description

add a description of your changes here...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

allformless
allformless previously approved these changes Jun 11, 2026
@allformless
allformless changed the base branch from master to develop June 11, 2026 09:06
@allformless
allformless dismissed their stale review June 11, 2026 09:06

The base branch was changed.

@allformless

Copy link
Copy Markdown
Contributor

please rebase to develop

@Inna333-cuber Inna333-cuber changed the title docs; fixed link readme docs: fix broken README link Jun 15, 2026
@hashdit-bot

hashdit-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

Pull Request Review

This PR updates documentation and generation tooling for genesis files, including fixing the README license link and adjusting naming mappings in the hardfork bytecode checker script. It also changes the testnet generation flow to output directly to genesis-testnet.json and reduces lock_period_for_token_recover in testnet config from 1 days to 300 seconds, resulting in updated bytecode in genesis-testnet.json. Overall, this is primarily a config/docs/tooling update with regenerated genesis artifacts.

Sensitive Content

Blockchain Address:

  • 0x30151DA466EC8AB345BEF3d6983023E050fb0673 (Ethereum-style address) in scripts/generate.py — testnet protector addresses
  • 0x08E68Ec70FA3b629784fDB28887e206ce8561E08 (Ethereum-style address) in scripts/generate.py — mainnet protector addresses

Security Issues

🟡 [MEDIUM] Access control is relaxed in dev-only code path (please confirm intent)

File: scripts/generate.py
In generate_gov_hub(), for network == "dev", the replacement removes onlyCrossChainContract from handleSynPackage(...), which weakens access control. This appears intentional for dev usage, but it is still an access-control relaxation pattern that should be explicitly verified to never affect mainnet/testnet artifacts.
Recommendation: Ensure this replacement is strictly gated to dev builds, add safeguards/tests preventing accidental inclusion in production genesis generation, and document this behavior clearly.

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants