Skip to content

Fix specialty keytags showing by default when the setting is off (#24) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjaudiomv merged 2 commits into from
Jul 17, 2026
Merged

Fix specialty keytags showing by default when the setting is off (#24) #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f06db67
Fix specialty keytags showing by default when setting is off (#24)
dgershman Jul 17, 2026
3015524
Merge branch 'main' into feature/nacc-24-special-keytags-default-off
pjaudiomv Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nacc-wordpress-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class NACC {
private const DEFAULT_THEME = 'NACC-Instance';
private const DEFAULT_LANGUAGE = 'en';
private const DEFAULT_LAYOUT = 'linear';
private const DEFAULT_SHOW_SPECIAL = 'true';
private const DEFAULT_SHOW_SPECIAL = false;

private $plugin_dir;
/**
Expand Down Expand Up @@ -140,7 +140,7 @@ private static function render_keytags( array $args ): void {
wp_json_encode( esc_attr( $args['theme'] ) ),
wp_json_encode( esc_attr( $args['language'] ) ),
wp_json_encode( esc_attr( $args['layout'] ) ),
wp_json_encode( esc_attr( $args['special'] ) ),
wp_json_encode( (bool) $args['special'] ),
wp_json_encode( esc_attr( $args['siteURI'] ) )
)
);
Expand Down Expand Up @@ -316,6 +316,7 @@ public static function register_settings(): void {
'nacc_special',
[
'type' => 'boolean',
'default' => self::DEFAULT_SHOW_SPECIAL,
'sanitize_callback' => 'wp_validate_boolean',
]
);
Expand Down
1 change: 1 addition & 0 deletions readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ That text will be replaced with this cleantime calculator.

= 6.0.2 =

* Fixed the "Show Special Keytags" default so that specialty (over 2 years) tags stay hidden until the setting is explicitly enabled, matching the unchecked checkbox and "Default is false." label.
* Added a "How to Use" help section to the Settings → NACC admin page documenting the `[nacc]` shortcode, its attributes, and what each setting does.

= 6.0.1 =
Expand Down