fix(core): respect rememberMe flag for session persistence#4
Open
klaudia-blazyczek-blurify wants to merge 1 commit into
Open
fix(core): respect rememberMe flag for session persistence#4klaudia-blazyczek-blurify wants to merge 1 commit into
klaudia-blazyczek-blurify wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed sessions incorrectly persisting after browser close regardless of "Remember me" checkbox state. Sessions now respect the rememberMe flag: unchecked → session-only (cleared on browser close), checked → 30-day persistent.
Changes
pam/identitymodule):auth.ts: Removed hardcodedrememberMeDurationconfig that forced all sessions to 30-day persistenceidentity.service.ts: ModifiedforwardCookies()to conditionally setMax-Ageheader based onrememberMeflag passed from login handlerAcceptance criteria
Checklist
pnpm verifyis green (typecheck + lint + boundaries + module-shape + tests)pnpm verify:driftis green (catalog / OpenAPI not stale)Notes
auth_tokenshould have NOMax-Age/Expiresauth_tokenshould haveMax-Age: 2592000