fix: set aquisition ID to before setting file prefix - #1310
Merged
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestCommunicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here. |
coretl
approved these changes
Jun 23, 2026
Collaborator
|
Merge when you're ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upon testing on i15, we found that setting
acquisition_idresults in no meta data being written. This is because this fanout signal does not put toEF.acqid, so images received from the fan are not set to the right ID. Further testing showed that settingEF.acqidtofilename(alongside IDs onFPs andMW) results in FP errors, where:Thus, acquisition ID must be set to a specific series number on all plugins. Acquisition ID is not used on i15 and i19, and I believe it is not used anywhere else. Therefore, we can simply set acquisition ID to
"", which uses default writers on all plugins, such that anything popped off ofEFis processed. This needs to be done before settingfile_nameandfile_prefixasMWwill setacquisition_IDtoNone, which must be unset before putting toMW.file_nameorMW.file_prefix, andacquisition_IDbeing a fanout intofile_prefixattributes means it needs to be set first to not override.