Skip to content

fix: set aquisition ID to before setting file prefix - #1310

Merged
shihab-dls merged 6 commits into
mainfrom
data_logic_fix
Aug 11, 2026
Merged

fix: set aquisition ID to before setting file prefix#1310
shihab-dls merged 6 commits into
mainfrom
data_logic_fix

Conversation

@shihab-dls

@shihab-dls shihab-dls commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Upon testing on i15, we found that setting acquisition_id results in no meta data being written. This is because this fanout signal does not put to EF.acqid, so images received from the fan are not set to the right ID. Further testing showed that setting EF.acqid to filename (alongside IDs on FPs and MW) results in FP errors, where:

FP.FrameProcessorPlugin ERROR - Received image message with series_number 2067 - expecting 2065 - ignoring

Thus, acquisition ID must be set to a specific series number on all plugins. Acquisition ID is not used on i15 and i19, and I believe it is not used anywhere else. Therefore, we can simply set acquisition ID to "", which uses default writers on all plugins, such that anything popped off of EF is processed. This needs to be done before setting file_name and file_prefix as MW will set acquisition_ID to None, which must be unset before putting to MW.file_name or MW.file_prefix, and acquisition_ID being a fanout into file_prefix attributes means it needs to be set first to not override.

@shihab-dls shihab-dls mentioned this pull request Jun 23, 2026
@checkmarx-gh-ast-us-povs

checkmarx-gh-ast-us-povs Bot commented Jun 23, 2026

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Detailsb6e4aaf6-9dde-443b-853c-87a4acf09ad4

Great job! No new security vulnerabilities introduced in this pull request


Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here.

@shihab-dls
shihab-dls requested a review from coretl June 23, 2026 11:24
@coretl

coretl commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Merge when you're ready

@shihab-dls
shihab-dls merged commit 875fe7d into main Aug 11, 2026
43 of 44 checks passed
@shihab-dls
shihab-dls deleted the data_logic_fix branch August 11, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants