Skip to content

chore(deps): remove unused msw #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SeijDeLeon merged 2 commits into from
Jul 31, 2026
Merged

chore(deps): remove unused msw #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c21a93
chore(deps): remove unused msw
CammilleCC Jul 28, 2026
43fc404
docs: drop stale service worker mentions
CammilleCC Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const config: StorybookConfig = {
...config,
STORYBOOK_FINCH_VERSION: pkg.version,
}),
staticDirs: ['../public'], //added this to support mws for api call mocks, see public/mockServiceWorker.js
staticDirs: ['../public'],
async viteFinal(config) {
return mergeConfig(config, {
base: '/finch/',
Expand Down
1 change: 0 additions & 1 deletion .storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ const preview: Preview = {
},
},
},
loaders: [],
};

export default preview;
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ The build can be viewed at [https://www.npmjs.com/package/@blueskyproject/finch]
### Updating Storybook on GH Pages
Storybook is updated automatically via github actions on merges into main. Manual update methods are shown below.

Please note that storybook on gh pages is hosted with a /finch path, and local development is served at /. The storybook manager and service worker are configured to look at the current path before deciding where to make files available at.
Please note that storybook on gh pages is hosted with a /finch path, and local development is served at /. The storybook manager is configured to look at the current path before deciding where to make files available at.

After making changes to Storybook, commit.

Expand Down
3 changes: 1 addition & 2 deletions Repo Instructions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ Top-level structure

`public/`
Static assets used by the demo app and Storybook, including Finch images,
icons, `finch.config.json`, and `mockServiceWorker.js` for MSW-backed
Storybook or test mocks.
icons, and `finch.config.json`.

`src/`
Main source tree for the library, demo app, API hooks, components, features,
Expand Down
Loading
Loading