Implement ophyd device simulation by Prinstar · Pull Request #49 · bluesky/finch

Prinstar · 2026-07-20T20:15:34Z

Summary

Added simulated ophyd motors, detectors, signals, and shutters
Implemented beamline simulation scenarios
Added EndstationDisplay and shutter controls
Updated socket communication for simulated devices
Added unit tests for simulated components

Testing

Verified simulated devices update correctly
Ran simulation tests for beamstop, detector, and shutter

github-actions · 2026-07-20T20:16:00Z

❌ Test Results

Some tests failed.

Complete Test Suite Coverage:

❌ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
❌ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
❌ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
❌ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
❌ Tiled - TiledComponents, TiledLinePlotMaker
❌ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
❌ Services - QueueServer, SignalMonitorPlots, Experiment
❌ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils

Test Environment: Node.js 20.x
Linting: ❌ ESLint failed
Formatting: ❌ Prettier failed
Type Checking: ❌ TypeScript compilation failed
Build: ❌ Production build successful
Tests: ❌ Some tests failed

SeijDeLeon · 2026-07-21T16:56:45Z

Please fix github actions test error

npm error code EUSAGE
npm error
npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.

It appears there is a missing component used in the TestPage which prevents the app from running (probably exists locally but wasn't added to a commit)

[plugin:vite:import-analysis] Failed to resolve import "@/components/HubHeader" from "src/app/pages/TestPage.tsx". Does the file exist?
/Users/seij/Repos/finch/src/app/pages/TestPage.tsx:20:41
34 |  import EnergyVsCurrentPlotPV from "@/components/EnergyVsCurrentPlotPV";
35 |  import Button from "@/components/Button";
36 |  import { HUB_HEADER_RIGHT_SLOT_ID } from "@/components/HubHeader";

- Convert single-assignment let bindings to const in createFallbackTransport - Remove unused imports (TableDeviceController, BluetoothSlash) - Add missing useMemo dependency in Beamstop - Finish Hub→Finch rename: FinchHeader component/props and FINCH_HEADER_RIGHT_SLOT_ID, fix TestPage import path - Resync package-lock.json so `npm ci` passes in CI Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Formatting-only changes surfaced by the format:fix pre-commit hook, which runs across the whole src tree. No behavior changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-07-21T17:56:35Z

✅ Test Results

All tests passed!

Complete Test Suite Coverage:

✅ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
✅ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
✅ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
✅ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
✅ Tiled - TiledComponents, TiledLinePlotMaker
✅ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
✅ Services - QueueServer, SignalMonitorPlots, Experiment
✅ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils

Test Environment: Node.js 20.x
Linting: ✅ ESLint passed
Formatting: ✅ Prettier passed
Type Checking: ✅ TypeScript compilation successful
Build: ✅ Production build successful
Tests: ✅ All tests passed

github-actions · 2026-07-21T19:46:09Z

✅ Test Results

All tests passed!

Complete Test Suite Coverage:

✅ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
✅ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
✅ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
✅ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
✅ Tiled - TiledComponents, TiledLinePlotMaker
✅ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
✅ Services - QueueServer, SignalMonitorPlots, Experiment
✅ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils

Test Environment: Node.js 20.x
Linting: ✅ ESLint passed
Formatting: ✅ Prettier passed
Type Checking: ✅ TypeScript compilation successful
Build: ✅ Production build successful
Tests: ✅ All tests passed

github-actions · 2026-07-22T20:31:26Z

✅ Test Results

All tests passed!

Complete Test Suite Coverage:

✅ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
✅ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
✅ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
✅ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
✅ Tiled - TiledComponents, TiledLinePlotMaker
✅ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
✅ Services - QueueServer, SignalMonitorPlots, Experiment
✅ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils
✅ Ophyd Sim - beamstopModel, createFallbackTransport, simCameraSocket, dependencyGraph, detector, hexapod, motor, shutter, signal, state, transport, useOphydPVSocket

Test Environment: Node.js 20.x
Linting: ✅ ESLint passed
Formatting: ✅ Prettier passed
Type Checking: ✅ TypeScript compilation successful
Build: ✅ Production build successful
Tests: ✅ All tests passed

Prinstar · 2026-07-22T20:38:46Z

-Add SimulatedBeamline feature and refactor beamline device table

Group the sim beamline (endstation, detector, device table, current
plot, floating shutter) into a self-contained SimulatedBeamline feature;
reduce TestPage to render it
Move EnergyVsCurrentPlotPV from components to features; add unit tests
TableDeviceControllerWithRBV: scroll on fixed height, and collapse the
relative-move column into a move-mode dropdown
Extract OphydSimContext/OphydTransportContext into their own modules

…ning

github-actions · 2026-07-24T17:23:40Z

✅ Test Results

All tests passed!

Complete Test Suite Coverage:

✅ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
✅ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
✅ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
✅ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
✅ Tiled - TiledComponents, TiledLinePlotMaker
✅ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
✅ Services - QueueServer, SignalMonitorPlots, Experiment
✅ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils
✅ Ophyd Sim - beamstopModel, createFallbackTransport, simCameraSocket, dependencyGraph, detector, hexapod, motor, shutter, signal, state, transport, useOphydPVSocket

Test Environment: Node.js 20.x
Linting: ✅ ESLint passed
Formatting: ✅ Prettier passed
Type Checking: ✅ TypeScript compilation successful
Build: ✅ Production build successful
Tests: ✅ All tests passed

github-actions · 2026-07-29T19:41:22Z

✅ Test Results

All tests passed!

Complete Test Suite Coverage:

✅ Buttons - Button, ButtonIconOnly, ButtonWithIcon, ButtonCopyToClipboard
✅ Inputs - InputCheckBox, InputNumber, InputEnumBoxRounded, InputStringBoxRounded
✅ Plots - PlotlyHeatmap, PlotlyHeatmapTiled, PlotlyScatter, Histogram, ColormapPicker
✅ Layout - Sidebar, SidebarItem, FinchSidebar, FinchAppLayout, FinchHeader, FinchMainContent, Header, Main, Bento, Paper, Widget
✅ Tiled - TiledComponents, TiledLinePlotMaker
✅ Devices - Camera, Shutter, DeviceControllerBox, DeviceControllerBoxSimple, TableDeviceController, ControllerAbsoluteMove, ControllerRelativeMove, Hexapod, BeamEnergy
✅ Services - QueueServer, SignalMonitorPlots, Experiment
✅ Misc - IFrame, GoogleDoc, SelectDropdown, ComponentViewer, ComponentViewerUtils
✅ Ophyd Sim - beamstopModel, createFallbackTransport, simCameraSocket, dependencyGraph, detector, hexapod, motor, shutter, signal, state, transport, useOphydPVSocket

Test Environment: Node.js 20.x
Linting: ✅ ESLint passed
Formatting: ✅ Prettier passed
Type Checking: ✅ TypeScript compilation successful
Build: ✅ Production build successful
Tests: ✅ All tests passed

Prinstar added 5 commits July 20, 2026 11:34

add files

644474d

add more files

7ee7475

Add ophyd-sim with sim motors, signals and detectors

e75e6ee

Implement EndstationDisplay and shutter control UI

59bbea6

Implement ophyd device simulation

46dea11

Prinstar and others added 2 commits July 21, 2026 10:50

Apply Prettier formatting to pre-existing files

cdf95b6

Formatting-only changes surfaced by the format:fix pre-commit hook, which runs across the whole src tree. No behavior changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Limit sim camera to 10 fps

c5a2978

Add SimulatedBeamline feature and refactor beamline device table

84ce7a0

shutter on the top left of the beamline cartoon with absolute positio…

677ab76

…ning

Prinstar added 2 commits July 27, 2026 11:24

Updated skills.md and formatting issues

f276f3e

added readme.md

135fd97

SeijDeLeon merged commit 30680bc into staging Jul 29, 2026
2 checks passed

Navigation Menu

Uh oh!

Implement ophyd device simulation - #49

Implement ophyd device simulation#49
SeijDeLeon merged 12 commits into
stagingfrom
sim-socket

Prinstar commented Jul 20, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

SeijDeLeon commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 22, 2026

Uh oh!

Prinstar commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Prinstar commented Jul 20, 2026

Summary

Testing

Uh oh!

github-actions Bot commented Jul 20, 2026

❌ Test Results

Uh oh!

SeijDeLeon commented Jul 21, 2026

Uh oh!

github-actions Bot commented Jul 21, 2026

✅ Test Results

Uh oh!

github-actions Bot commented Jul 21, 2026

✅ Test Results

Uh oh!

github-actions Bot commented Jul 22, 2026

✅ Test Results

Uh oh!

Prinstar commented Jul 22, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

✅ Test Results

Uh oh!

github-actions Bot commented Jul 29, 2026

✅ Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants