Use read_block when reading slices of the entire arrays - #880
Merged
Conversation
|
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here. |
danielballan
approved these changes
May 27, 2026
danielballan
left a comment
Member
There was a problem hiding this comment.
Tested against the production MongoDB
Member
|
Oh, better bump minimum tiled version first! |
danielballan
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Use
read_blockmethods for reading slices of array data.Description
Motivation and Context
When reading slices of big arrays, Tiled by default calls the
.read(slice=...)method, which causes databroker to fetch data for the entire array, event hough most of it may be discarded during slicing. These changes allow the server to only fetch necessary chunks.How Has This Been Tested?
Utility functions are tested in Tiled. Full workflow is tested in a dev set-up with mounted MongoDB.