Support streaming RE waiting hook watcher updates over a new ZMQ topic - #357
Draft
jwlodek wants to merge 14 commits into
Draft
Support streaming RE waiting hook watcher updates over a new ZMQ topic#357jwlodek wants to merge 14 commits into
jwlodek wants to merge 14 commits into
Conversation
…g watcher updates from RE to progress msg queue
…he watcher stream manager
…progress publishing follow the same format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #353. Adds an additional zmq topic for streaming RE waiting hook progress updates. Adds additional CLI/config options to enable the feature + a waiting hook compatible class that posts the updates from the RE to zmq. Clients can then use these updates to construct progress bars and the like.
Motivation and Context
Currently, a common piece of feedback from BL staff that use queueserver is that there isn't enough feedback on the state of a scan as it is taking place. Being able to re-create something similar to the bluesky
ProgressBarManagerby using streamed RE updates should ameliorate this issue.Summary of Changes for Release Notes
Fixed
Added
Changed
Removed
How Has This Been Tested?
Added unit tests, and explicit local integration test