add GlobalStoppingAware protocol - #337
Merged
Merged
Conversation
thopkins32
requested changes
Aug 3, 2026
Comment on lines
+227
to
+228
| if stop_now: | ||
| print(f"Global stopping triggered at iteration {i + 1}: {stop_reason}") |
Collaborator
There was a problem hiding this comment.
What if stop_reason is None?
Collaborator
|
Would using "...aware" be a misnomer as the optimizer would be emitting the global stop command/signal. I would think something like "GlobalStopSignaling/able" if using mixin naming or "GlobalStopSignal" if using protocol object naming would be clearer. |
thopkins32
approved these changes
Aug 3, 2026
thopkins32
left a comment
thopkins32
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, may suggest a follow-up name change to HasStoppingCriteria or SupportsStoppingCondition but functionally this looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start of adding a global early stopping condition.