Prevent crashes on bare Varbind arguments - #17
Merged
SoundGoof merged 1 commit intoJul 23, 2026
Conversation
SoundGoof
force-pushed
the
fix/issue-5-bare-varbind-crash
branch
from
July 23, 2026 21:12
5e8e829 to
ef13d30
Compare
bluecmd
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5 by preventing interpreter crashes when a bare
Varbindis passed to session methods that require aVarList.Invalid arguments now produce direct Python exceptions instead of segmentation faults or secondary
SystemErrorexceptions.Root Cause
The native extension called
PyObject_GetIter()but did not check whether iterator creation succeeded.When a bare, non-iterable
Varbindwas supplied, iterator creation returnedNULLand set a Python exception. Several methods then passed the null pointer to another API or decremented its reference count, causing a segmentation fault.Other methods returned a value while an exception was still active, which Python reported as a
SystemError.Changes
NULLfrom native methods when a Python exception is active.getgetnextsetwalkgetbulkBehavior
Before this change:
get,getnext, andsetterminated the interpreter withSIGSEGV.walkandgetbulkraisedSystemError.After this change:
get,getnext, andsetraiseTypeError.walkandgetbulkraiseAttributeError.Testing