fix(dnf): use str starts-with for record type check in install_pkgs#572
Merged
Merged
Conversation
Nushell's describe returns the full type signature for records
("record<key: type, ...>"), not just "record". The equality check
== 'record' is therefore always false, silently skipping all
repo-specific package installs (terra, COPR, etc.).
Fix matches the existing pattern already used in add_coprs.
Closes blue-build#571
Contributor
Author
|
I tested this fix in my repo (https://github.com/fromelicks/secureblue-blue-build/blob/main/recipes/recipe.yml#L21) and it works nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Nushell,
describeon a record returns the full type signature (e.g.record<repo: string, packages: list<string>>), not just"record", so the equality check introduced in #564 always fails and silently skips all repo-specific package installs. Fix matches the pattern already used inadd_coprs.Closes #571