Skip to content

Hooray google ads #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manoj-07 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hooray google ads #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2b5b41
updated google-ads version 0.1.43
Manoj-07 Apr 27, 2023
d82649e
hooray_googleads
Manoj-07 Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/253487c0-2246-43ba-a21f-5116b20a2c50.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "253487c0-2246-43ba-a21f-5116b20a2c50",
"name": "Google Ads",
"dockerRepository": "blotout/source-google-ads",
"dockerImageTag": "0.1.43",
"dockerImageTag": "2.9",
"documentationUrl": "https://hub.docker.com/r/airbyte/source-google-ads"
}
4 changes: 2 additions & 2 deletions airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
- name: Google Ads
sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
dockerRepository: blotout/source-google-ads
dockerImageTag: 0.1.43
dockerImageTag: 2.9
documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
sourceType: api
- name: Google Analytics
Expand Down Expand Up @@ -507,7 +507,7 @@
- name: Shopify
sourceDefinitionId: 9da77001-af33-4bcd-be46-6252bf9342b9
dockerRepository: blotout/source-shopify
dockerImageTag: 0.1.28
dockerImageTag: 0.1.30
documentationUrl: https://docs.airbyte.io/integrations/sources/shopify
sourceType: api
- name: Short.io
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "blotout/source-google-ads:0.1.43"
- dockerImage: "blotout/source-google-ads:2.9"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/google-ads"
connectionSpecification:
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ COPY main.py ./

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.43
LABEL io.airbyte.name=airbyte/source-google-ads
LABEL io.airbyte.version=2.9
LABEL io.airbyte.name=blotout/source-google-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

# pin protobuf==3.20.0 as other versions may cause problems on different architectures
# (see https://github.com/airbytehq/airbyte/issues/13580)
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==17.0.0", "protobuf==3.20.0", "pendulum"]
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==20.0.0", "protobuf==4.21.5", "pendulum"]

TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock", "freezegun", "requests-mock"]

Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import pendulum
from google.ads.googleads.client import GoogleAdsClient
from google.ads.googleads.v11.services.types.google_ads_service import GoogleAdsRow, SearchGoogleAdsResponse
from google.ads.googleads.v13.services.types.google_ads_service import GoogleAdsRow, SearchGoogleAdsResponse
from proto.marshal.collections import Repeated, RepeatedComposite

REPORT_MAPPING = {
Expand All @@ -30,7 +30,7 @@
"geographic_report": "geographic_view",
"keyword_report": "keyword_view",
}
API_VERSION = "v11"
API_VERSION = "v13"


class GoogleAds:
Expand Down
30 changes: 0 additions & 30 deletions ...tegrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ad_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,15 +222,6 @@
"ad_group_ad.ad.legacy_responsive_display_ad.format_setting": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.header_image": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.logo_image": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image": {
"type": ["null", "string"]
},
"metrics.gmail_forwards": {
"type": ["null", "integer"]
},
Expand All @@ -240,15 +231,6 @@
"metrics.gmail_secondary_clicks": {
"type": ["null", "integer"]
},
"ad_group_ad.ad.gmail_ad.teaser.business_name": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.description": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.text_ad.headline": {
"type": ["null", "string"]
},
Expand Down Expand Up @@ -294,18 +276,6 @@
"ad_group_ad.ad.legacy_responsive_display_ad.main_color": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_display_call_to_action.text": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_display_call_to_action.text_color": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_description": {
"type": ["null", "string"]
},
"segments.month": {
"type": ["null", "string"]
},
Expand Down
45 changes: 0 additions & 45 deletions ...yte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,51 +164,6 @@
"type": "string"
}
},
"ad_group_ad.ad.gmail_ad.header_image": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_description": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_display_call_to_action.text": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_display_call_to_action.text_color": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_display_call_to_action.url_collection_id": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.marketing_image_headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.product_images": {
"type": ["null", "array"],
"items": {
"type": "string"
}
},
"ad_group_ad.ad.gmail_ad.product_videos": {
"type": ["null", "array"],
"items": {
"type": "string"
}
},
"ad_group_ad.ad.gmail_ad.teaser.business_name": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.description": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.gmail_ad.teaser.logo_image": {
"type": ["null", "string"]
},
"ad_group_ad.ad.hotel_ad": {
"type": ["null", "string"]
},
Expand Down
3 changes: 0 additions & 3 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/campaigns.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,6 @@
"campaign.target_cpa.target_cpa_micros": {
"type": ["null", "integer"]
},
"campaign.target_cpm": {
"type": ["null", "string"]
},
"campaign.target_impression_share.cpc_bid_ceiling_micros": {
"type": ["null", "integer"]
},
Expand Down