Gigs Project Done#150
Open
NorlanT wants to merge 1 commit into
Open
Conversation
swift-student
left a comment
swift-student
left a comment
There was a problem hiding this comment.
Nice start to this project, Norlan!
Comment on lines
+46
to
+78
| do { | ||
| let encoder = JSONEncoder() | ||
| encoder.outputFormatting = .prettyPrinted | ||
| let jsonData = try encoder.encode(user) | ||
| print(String(data: jsonData, encoding: .utf8)!) | ||
| request.httpBody = jsonData | ||
|
|
||
| let task = URLSession.shared.dataTask(with: request) { (_, response, error) in | ||
|
|
||
| // Check for error first | ||
| if let error = error { | ||
| print("Sing up failed with error: \(error)") | ||
| completion(.failure(.failedSignUp)) | ||
| return | ||
| } | ||
|
|
||
| // Check for response and make sure is a 200 | ||
| guard let response = response as? HTTPURLResponse, | ||
| response.statusCode == 200 else { | ||
| print("Sign up was unsuccessful") | ||
| completion(.failure(.failedSignUp)) | ||
| return | ||
| } | ||
|
|
||
| completion(.success(true)) | ||
| } | ||
|
|
||
| task.resume() | ||
|
|
||
| } catch { | ||
| print("Error encoding user: \(error)") | ||
| completion(.failure(.failedSignUp)) | ||
| } |
There was a problem hiding this comment.
While there is nothing wrong with the way you wrote this, I would personally prefer to wrap the do catch block more directly around the line doing the try to make it clear what is going to throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@swift-student