Humberto Raya /back-end-project-week#495
Open
hraya wants to merge 11 commits into
Open
Conversation
began to add dependecies began file structure
will seed some data for testing purposes
began to set up dbConfig file
completed the get all notes endpoint
all endpoints work properly, tested through postman
Author
deploying to heroku
johnoro
reviewed
Mar 4, 2019
johnoro
left a comment
johnoro
left a comment
There was a problem hiding this comment.
Looks great! It'd be a good idea to include your deployed link somewhere easily visible for people like me.
| .then(ids =>{ | ||
| db.findById(ids[0]) | ||
| .then(notes=>{ | ||
| res.status(201).json(note) |
There was a problem hiding this comment.
Notice the difference between the callback's parameter name and the name of the variable you're sending back: notes vs note. The data that you're sending back is the req.body that the client sent over. This doesn't include the new id since you're not sending back your innermost callback parameter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@johnoro