Abdiel Fernandez#491
Open
CBMR wants to merge 51 commits into
Open
Conversation
KingAtoki
reviewed
Feb 21, 2019
| table.increments(); | ||
|
|
||
| table.string('title', 255).notNullable(); | ||
| table.string('content', 10000).notNullable(); |
There was a problem hiding this comment.
You could also do something like this
Suggested change
| table.string('content', 10000).notNullable(); | |
| table.text('content').notNullable(); |
KingAtoki
reviewed
Feb 21, 2019
|
|
||
| const server = require('./server/server'); | ||
|
|
||
| PORT = process.env.PORT || 4500 |
There was a problem hiding this comment.
Missing a const here
Suggested change
| PORT = process.env.PORT || 4500 | |
| const PORT = process.env.PORT || 4500 |
KingAtoki
reviewed
Feb 21, 2019
KingAtoki
left a comment
KingAtoki
left a comment
There was a problem hiding this comment.
Everything looks 100% great! You code is clean and you used all the best practices. Nice job!
Authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@KingAtoki
The link to my trello board is in the READme. I will try to properly update it tomorrow.