Kyle Baker#485
Open
kybak wants to merge 11 commits into
Open
Conversation
|
Make sure to |
KingAtoki
reviewed
Feb 22, 2019
| return db('notes') | ||
| .where('id', id) | ||
| .update(changes) | ||
| .then(count => (count > 0 ? this.get(id) : null)); |
KingAtoki
reviewed
Feb 22, 2019
| const saltRounds = 10; | ||
|
|
||
| if (!user_name || !email || !password || !name) { | ||
| console.log('Missing information'); |
There was a problem hiding this comment.
Make sure to remove the console.log statements when commiting
Suggested change
| console.log('Missing information'); |
KingAtoki
reviewed
Feb 22, 2019
| return res.status(400).json({ error: "Missing information" }); | ||
| } | ||
|
|
||
| console.log('Registering'); |
There was a problem hiding this comment.
Suggested change
| console.log('Registering'); |
KingAtoki
reviewed
Feb 22, 2019
|
|
||
| console.log('Registering'); | ||
|
|
||
| req.body.password = await bcrypt.hash(password, saltRounds).then(hash => hash); |
There was a problem hiding this comment.
For this .then(hash => hash); if you are just returning what you are getting, do you even need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@KingAtoki