Mitchell Robles - back-end-project-week#480
Open
mitchellr92 wants to merge 16 commits into
Open
Conversation
… set up basic structure for endpoints
johnoro
reviewed
Mar 4, 2019
| - Share your board with the project manager that has been assigned to you. If you have not been assigned yet, reach out to your Section Lead for guidance. | ||
| - Add your Trello URL to your project's README.md file. Commit the change, push it to your repository & submit a pull request. | ||
|
|
||
| https://trello.com/b/R1umQ7aa/lambda-notes-backend-mitchell-robles |
| const { id } = req.params; | ||
|
|
||
| db('notes').where({ id }).del() | ||
| .then(note => { |
There was a problem hiding this comment.
This parameter is called note, but is it actually? (It should be a count of sorts, typically being 1, of how many entries were deleted.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@johnoro
Not as much done tonight as I was hoping. Had to some trouble shooting on my end