back-end-project-week: Megan Fontenot#478
Open
meganfontenot wants to merge 16 commits into
Open
Conversation
meganfontenot
force-pushed
the
megan-fontenot
branch
from
February 13, 2019 04:11
ef013bd to
3a27e46
Compare
knexfile.js: migrations and seeds path set. notes_table migration ran.
johnoro
reviewed
Mar 4, 2019
johnoro
left a comment
There was a problem hiding this comment.
Ignore your node_modules!
Looks great, Megan!
| }, | ||
|
|
||
| editNote: (id, note) => { | ||
| return db("notes").where("id", id).update(note); |
There was a problem hiding this comment.
Why not use your already existing dbConfig helpers rather than recreating them?
|
|
||
| exports.seed = function(knex, Promise) { | ||
| // Deletes ALL existing entries | ||
| return knex('table_name').del() |
There was a problem hiding this comment.
I'm assuming 'table_name' here is meant to be 'notes'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@johnoro
Trello Link: https://trello.com/b/YjXXvCsr/lambda-notes-backend-megan-fontenot
Backend MVP Features:
SQLite3.Extra Features: