Responsive-Design-2#876
Conversation
lolax
left a comment
lolax
left a comment
There was a problem hiding this comment.
Great work on this project, Christian. You were thorough with your switch to a fully responsive design. My only recommendation is that you avoid using percentages for height and top/bottom padding & margins because we don't want to shrink everything on small screen dimension, just make it more minimal and longer/narrower. Vertical scrolling is expected so it's okay for elements to be a little tall, horizontal scrolling is what we want to eliminate. Nice work! 💯
| flex-direction: row; | ||
| justify-content: center; | ||
| width: 70%; | ||
| height: 8%; |
There was a problem hiding this comment.
Avoid using percentages for heights and top/bottom margins & padding. Vertical scroll bars are perfectly fine and we don't want content to get super squished if someone's window height is small, they will just have to scroll more downwards.
|
|
||
| .button { | ||
| border: 1px solid black; | ||
| width: 30%; |
There was a problem hiding this comment.
Nice job with the percentages for widths
| } | ||
| /* =========== Mobile View ===========*/ | ||
|
|
||
| @media (max-width: 500px) { |
2 participants
No description provided.