Jonathan Gistand - Responsive-Web-Design-II#875
Conversation
lolax
left a comment
lolax
left a comment
There was a problem hiding this comment.
Really nice work on this project, Jonathan! I left a few comments pointing towards potential improvements below. You've demonstrated a solid understanding of responsive design. Keep it up! 💯
| justify-content: space-around; | ||
| align-content: column; | ||
| margin: 0 auto; | ||
| padding: 2% 0%; |
There was a problem hiding this comment.
Try to avoid using percentages for vertical (top & bottom) padding or margins because screen size is generally dictated by its width
| align-content: flex-start; | ||
| padding-top: 12px; | ||
| margin: 4rem; | ||
| padding-right: 750px; |
There was a problem hiding this comment.
On the converse, try to use percentages for left-right padding/margins so that they scale with screen size :)
| } | ||
|
|
||
| .footer { | ||
| display: flex; |
There was a problem hiding this comment.
It's a technical necessity and in this case it's a small difference, but I encourage you to try to use consistent spacing to make your code easier for you and others to read.
|
|
||
| /* Mobile Specs */ | ||
|
|
||
| @media (max-width: 500px) { |
2 participants
No description provided.