Init pull#871
Open
Nathan-Culver wants to merge 3 commits into
Open
Conversation
GannonDetroit
left a comment
GannonDetroit
left a comment
There was a problem hiding this comment.
Nathan, everything looks good with the design file, but your tablet view seems to have a good amount of extra white space under the "get started" button and the line beneth it, see if you can close that gap a little. The Mobile view for "innovation on demand" is a bit off as well. It's too small. I have a horizontal scroll bar when i use it. This is most likely because of the pixel units you're still using. Speaking of, you're still using pixels for quite a few things in the CSS. Try to use your dev tools to turn those pixels into percertages. (padding, margins, things like that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.