responsive webdesign 2/incomplete#863
Open
RodBromberg wants to merge 1 commit into
Open
Conversation
ielvisd
reviewed
Jan 8, 2019
ielvisd
left a comment
ielvisd
left a comment
There was a problem hiding this comment.
Look into what flexbox properties you can use to center the title on tablet/mobile views. Also you could add a rem font size to your headers and footer text to make those not tiny. Good job overall.
| align-items: center; | ||
| justify-content: center; | ||
| margin: 0 auto; | ||
| } |
There was a problem hiding this comment.
max-width instead of width would get rid of your horizontal scroll bar.
Good use of margin: 0 auto to center your content.
| body { | ||
| height: 100%; | ||
| font-family: 'Titillium Web', sans-serif; | ||
| font-size: 62.5%; |
There was a problem hiding this comment.
Good use of 62.5% font size to standardize your rem sizes across your site.
|
|
||
| /* Media Query Tablet */ | ||
|
|
||
| @media only screen and (max-width: 800px) { |
There was a problem hiding this comment.
Good use of media queries to change the look of your site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ielvisd