LambdaMUD-Project - Jonathan Laluces#136
Open
jlaluces123 wants to merge 5 commits into
Open
Conversation
TheDeterminator
left a comment
TheDeterminator
left a comment
There was a problem hiding this comment.
Jonathan, you have a lot of good work here! Try to go continue pushing yourself with stretch goals and extra features if you find time to look more at this project. Great job!
| def say(request): | ||
| # IMPLEMENT | ||
| return JsonResponse({'error':"Not yet implemented"}, safe=True, status=500) | ||
| player = request.user.player # --> Grab player |
There was a problem hiding this comment.
Good comment here, would be nice to have a few more throughout your code.
| room = player.room() # --> Grab room | ||
| currentPlayerUUIDs = room.playerUUIDs(player_id) | ||
| for uuid in currentPlayerUUIDs: | ||
| pusher.trigger(f'p-channel-{uuid}', u'broadcast', {'say': f'{player.user.username} says {response}'}) |
There was a problem hiding this comment.
I think this broadcasts an alert to the player who said the message too, but ideally you would want to exclude the player who performed say from the list of who receives the alert. This differentiates "say" from "shout"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.