Deployed and working on login and registration on front end - Benny Oseguera#134
Open
bennyo27 wants to merge 2 commits into
Open
Deployed and working on login and registration on front end - Benny Oseguera#134bennyo27 wants to merge 2 commits into
bennyo27 wants to merge 2 commits into
Conversation
TheDeterminator
left a comment
TheDeterminator
left a comment
There was a problem hiding this comment.
Benny, you have a lot of solid work here. Only thing I might recommend is more frequent, detailed commits and maybe a few more comments in your code, all the same, great job!
| room = player.room() | ||
| currentPlayerUUIDs = room.playerUUIDs(player_id) | ||
| for p_uuid in currentPlayerUUIDs: | ||
| pusher.trigger(f'p-channel-{p_uuid}', u'broadcast', {'message': f'<{player.user.username}> says "{message}"'}) |
There was a problem hiding this comment.
I think this sends a message to the player who performs the say command, yes? You might consider how it could send a message to everyone 'except' the player who performed the command. This is one way in which it might be differentiated from shout. Of course, shout also sends messages to players even if they are not in the room so that is another difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.