jcassidy#133
Conversation
TheDeterminator
left a comment
TheDeterminator
left a comment
There was a problem hiding this comment.
James, this code looks great! Good job getting through this assignment. I assume based off of your last commit message that you also had trouble with the "old_auth tables" bug that plagued so many people? Whatever the case good job getting through any blockers you may have faced while doing this code. By way suggestion you could add a few more comments to your code (although I appreciate taht most of it was prewritten for this assignment). And you should name our PRs: [FirstName LastName] - Name-Of-Project. I don't know if your PM has ever said explicitly but it will make it easier for him to find your pull requests. All the same, great job!
| DEBUG = config('DEBUG', cast=bool) | ||
|
|
||
| ALLOWED_HOSTS = [] | ||
| ALLOWED_HOSTS = os.environ.get("ALLOWED_HOSTS").split(",") |
There was a problem hiding this comment.
This is interesting, you could also have casted to a csv() type to get similar functionality.
| saidmessage = data['saidmessage'] | ||
| room = player.room() | ||
| currentPlayerUUIDs = room.playerUUIDs(player_id) | ||
| for p_uuid in currentPlayerUUIDs: |
There was a problem hiding this comment.
This is good, have you thought about the case when a user tries to break your functionality by sending an empty message? If you really wanted to stretch you could think about how other types of input based attacks might be handled by this code but that is beyond the scope of this project.
| @@ -1,3 +1,5 @@ | |||
| pip freeze > requirements.txt | |||
|
|
|||
There was a problem hiding this comment.
When did you run pip freeze? I thought there might be more modules in this file but maybe not.
2 participants
No description provided.