LambdaMUD - Wonjae Hwang, PM Adrian Adames#127
Open
verydecent wants to merge 4 commits into
Open
Conversation
TheDeterminator
left a comment
There was a problem hiding this comment.
Wonjae, this code looks great! If you haven't already I hope you will go back and implement the say command as well as any other goals, MVP, Stretch or otherwise. Overall though, Good job!
| @@ -1,3 +1,7 @@ | |||
| # Trello Link | |||
|
|
|||
| https://trello.com/b/6FZkyg66/lambdamud-wonjae-hwang | |||
There was a problem hiding this comment.
Good that you added your trello link here, it's a small thing but many students forget and it's important for documenting your code.
| } | ||
|
|
||
| db_from_env = dj_database_url.config(conn_max_age=500) | ||
| DATABASES['default'].update(db_from_env) |
There was a problem hiding this comment.
This is interesting syntax. It may be the first time I've seen it so far but it's very semantic which is good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello Link - https://trello.com/b/6FZkyg66/lambdamud-wonjae-hwang
Trello Set Up:
backlog,To Do,In Progress, andDoneTo Dolist with the MVP features listed belowbackloglist with all the extra features listed belowMVP Features:
Client
saycommand to say things that other people in the room will see (server implementation incomplete)p-channel-<uuid>broadcastevents and display the messages to the playerServer
saywhich broadcasts a message to other players in the current roomGeneral