hashtables #162
Open
DavidBenavidez123 wants to merge 1 commit into
Open
Conversation
| { | ||
| BasicHashTable *ht; | ||
| BasicHashTable *ht = malloc(sizeof(BasicHashTable)); | ||
| ht->storage = calloc(capacity, sizeof(Pair *)); |
| if(ht->storage[hashedkey] != NULL) { | ||
| printf("Overwriting a value."); | ||
| // clear stored value | ||
| destroy_pair(ht->storage[hashedkey]); |
There was a problem hiding this comment.
I'm not sure this is strictly necessary, but it doesn't hurt.
|
|
||
| unsigned int hashedkey = hash(key, ht->capacity); | ||
| // if key even exists then clear ky value pair | ||
| if(ht->storage[hashedkey] != NULL) { |
There was a problem hiding this comment.
Very good job checking if this is not NULL.
| // check if value exists | ||
| if(ht->storage[hashedkey] != NULL) { | ||
| return ht->storage[hashedkey]->value; | ||
| } |
|
|
||
| // loop through each bucket | ||
| for(int i =0; i < ht->capacity; i++) { | ||
| destroy_pair(ht->storage[i]); |
| HashTable *ht; | ||
| HashTable *ht = malloc(sizeof(HashTable)); | ||
| ht->capacity = capacity; | ||
| ht->storage = calloc(capacity,sizeof(LinkedPair *)); |
There was a problem hiding this comment.
I believe this is sizeof(LinkedPair). If you wanted the size of the pointer, it would be sizeof(*LinkedPair).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.