Update exposer's Redis retry exception handling - #35
Open
aokhovat wants to merge 1 commit into
Open
Conversation
jacquesh
reviewed
Mar 6, 2026
| if not rs_conn.ping(): | ||
| raise Exception("connection established but redis is not pinging") | ||
| return rs_conn | ||
| except redis.exceptions.ConnectionError as ex: |
Contributor
There was a problem hiding this comment.
What non-ConnectionError exceptions are we expecting to catch here though? If its just the ping check above, could we not just remove that exception and replace it with a log, sleep & continue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist