Feat: S3 private bucket pre-signed URL generation integration#6494
Draft
matzduniuk wants to merge 18 commits into
Draft
Feat: S3 private bucket pre-signed URL generation integration#6494matzduniuk wants to merge 18 commits into
matzduniuk wants to merge 18 commits into
Conversation
matzduniuk
added
the
wip
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
YazeedLoonat
reviewed
Jul 9, 2026
YazeedLoonat
left a comment
YazeedLoonat
left a comment
Collaborator
There was a problem hiding this comment.
looks good overall left you some comments and the next steps for ya
lemme know if you have any questions or ran into anything
|
|
||
| const listingData = await this.prisma.listings.findUnique({ | ||
| select: { | ||
| jurisdictionId: true, |
Collaborator
There was a problem hiding this comment.
we should specify the listing id is responded here so we aren't returning the full listing object
Collaborator
Author
There was a problem hiding this comment.
We are already limiting the listing response object to only have the jurisdictionId and linked jurisdiction feature flags array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #6377
Description
'bulk-update/upload-url'endpointHow Can This Be Tested/Reviewed?
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: