Skip to content

fix: add six and seven bedrooms#6493

Open
KrissDrawing wants to merge 3 commits into
mainfrom
6458/Add-6-and-7+-bedroom-types
Open

fix: add six and seven bedrooms#6493
KrissDrawing wants to merge 3 commits into
mainfrom
6458/Add-6-and-7+-bedroom-types

Conversation

@KrissDrawing

Copy link
Copy Markdown
Collaborator

This PR addresses #6458

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds six and seven + bedrooms options.
Using google translate for this seemed wrong (as it returned inconsistent translations), so i used common sense and some AI so i cant guarantee if they are correct.

How Can This Be Tested/Reviewed?

run migration.
Units should have now 2 new options.
they will be visible on public listing site.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Jul 9, 2026
@netlify

netlify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 54b7747
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a4fbe3af7b6250008bf90c5
😎 Deploy Preview https://deploy-preview-6493--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 2407d03
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a4fbe24ea93bf000834aa20
😎 Deploy Preview https://deploy-preview-6493--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 2407d03
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a4fbe237378490008e3edde
😎 Deploy Preview https://deploy-preview-6493--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 54b7747
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a4fbe3ad549c000094f2b7e
😎 Deploy Preview https://deploy-preview-6493--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 54b7747
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a4fbe3af49d01000712c223
😎 Deploy Preview https://deploy-preview-6493--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@@ -1091,6 +1091,8 @@ export const typeMap = {
threeBdrm: 'Three Bedroom',
fourBdrm: 'Four+ Bedroom',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I know this is already existing, but shouldn't this be changed to Four Bedroom?

@@ -0,0 +1,3 @@
-- AlterEnum

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file name needs to be updated to the sequential number system we are using before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants