Skip to content

listing: skip amiChart findMany when no units carry an AMI chart #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

listing: skip amiChart findMany when no units carry an AMI chart #6316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions api/src/services/listing.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2963,13 +2963,18 @@ export class ListingService implements OnModuleInit {
addUnitsSummarized = async (listing: Listing) => {
if (Array.isArray(listing.units) && listing.units.length > 0) {
const unitsWithCharts = listing.units.filter((unit) => unit.amiChart?.id);
const amiChartsRaw = await this.prisma.amiChart.findMany({
where: {
id: {
in: unitsWithCharts.map((unit) => unit.amiChart?.id),
},
},
});
// Skip the findMany when none of the units carry an amiChart (e.g.
// when called from a view that doesn't select amiChart). Otherwise
// we'd run an `in: []` query that downstream views weren't expecting.
const amiChartsRaw = unitsWithCharts.length
? await this.prisma.amiChart.findMany({
where: {
id: {
in: unitsWithCharts.map((unit) => unit.amiChart?.id),
},
},
})
: [];
const amiCharts = mapTo(AmiChart, amiChartsRaw);
listing.unitsSummarized = summarizeUnits(listing, amiCharts);
}
Expand Down