Repository navigation
feat(analyzer): H.264 slice header fields and slice data info - #58
Merged
Merged
Conversation
Extend H264SliceHeader with the fields that depend on SPS/PPS and decode them when the slice header is available: field flags, idr_pic_id, delta POC, redundant count, ref index overrides and list modifications, reference marking, cabac_init_idc, QP/QS deltas and deblocking offsets. The NAL details panel now prints the header, the split between header and slice data, the entropy mode and a hex dump of the first 32 data bytes. H.265 slices get a basic header summary plus the same payload preview. RbspBitReader tracks consumed bits so the header size can be reported.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves #20: the NAL details panel now shows a real H.264 slice header and basic slice-data information instead of just a heading.
H.264
first_mb_in_slice,slice_type(numeric + name, "all slices" variants),pic_parameter_set_id,frame_numidr_pic_id, POC fields (lsb,delta_pic_order_cnt_bottom/[0]/[1])redundant_pic_cnt,direct_spatial_mv_pred_flagnum_ref_idx_active_override_flag+ l0/l1, number of ref-pic-list modificationscabac_init_idc,slice_qp_delta, SP/SI fields, deblocking offsetspred_weight_tableis detected but not decoded; the panel says later fields are not decoded instead of misreading them.H.265
Basic slice segment header (type, PPS id, POC, IRAP/IDR/dependent) plus payload size and hex preview. Full HEVC header fields (SAO, RPS, merge candidates, entry points) remain for a follow-up, so this PR references #20 without closing it.
Verification
ctest: 67/67 pass (newH264ParamsTest.BuildsSliceDetailsText)../test/tools/tidy.sh core/nalanalyzer.cpp core/h264types.cpp core/expgolomb.cpp test/test_h264_params.cpp: 0 issues.Refs #20