Repository navigation
feat(ui): add Help menu with shortcuts and links - #56
Merged
Merged
Conversation
- Keyboard Shortcuts dialog generated from QKeySequence so labels use the platform-native modifiers (Cmd on macOS, Ctrl elsewhere) - Documentation and Report an Issue open the GitHub pages - About stays in the application menu on macOS (Qt AboutRole) - add a GUI test for the Help menu entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #54: fills the Help menu, which was empty after Qt moved the About action to the application menu on macOS.
QKeySequence::toString(NativeText), so macOS shows Cmd and other platforms Ctrl; the recent-file range usesQKeyCombination.Verification
ctest: 65/65 pass (newHelpMenuHasEntriestest)../test/tools/tidy.sh mainwindow.cpp mainwindow.h test/test_gui.cpp: 0 issues.Fixes #54