fix(desktop): keep group DM message actions on-screen#1082
Closed
wesbillman wants to merge 1 commit into
Closed
Conversation
Keep the timeline content wrapper from expanding to group-DM intro min-content width so message rows and their hover action bars stay inside the viewport. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/group-dm-actionbar
branch
from
9e07164 to
ba007be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix group-DM timelines whose intro content can force the timeline content wrapper wider than the viewport. When that happens, even short later messages (for example
Hi) inherit the wide row width and their right-anchored hover action bar is clipped off-screen.This adds
min-w-0to the timeline reveal content wrapper so the group-DM intro and message list shrink within the visible timeline.Verification
Himessage.scrollWidthexpanded to2600whileclientWidthwas980; the action bar right edge was off-screen.scrollWidth == clientWidth == 980; row width956; action bar right edge1264in a1280viewport.cd desktop && ../bin/pnpm typecheckcd desktop && ../bin/pnpm checkexits 0; it still prints existing unrelated lint warnings inthread-unread-screenshots.spec.ts.Note
This replaces the earlier markdown-overflow framing in #1079 for the group-DM reaction-bar issue.