Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Wait for each signing gate so real crypto completion cannot reorder the requests under test. Assert the waiting request is rejected instead of dispatched after cooldown. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Arjun Mahanti <arjun@squareup.com>
Assert the fixture publication is accepted and the options are rendered before Arrow Up. The CI trace showed the key moving the textarea caret while React still had a pending completion render. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Arjun Mahanti <arjun@squareup.com>
mahanti
marked this pull request as ready for review
September 16, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bestie’s call panel now centers the companion and keeps call controls in a stable footer. Thinking and tool approval move into the header’s ellipsis menu; transcripts are hidden by default and can be toggled during a call.
Stacked on #37 and targeting
feat/bestie-realtime-voice, so this PR contains only the polish changes.Screenshots
Real UI with synthetic audio, isolated identities, and fixture text. All nine states, including connecting, speaking, muted, dark mode, and the compact layout.
Validation
All hosted checks passed at
e3ecb47: CI run, including all four browser shards, measurements, JavaScript, Rust/tool integration, and CI required. DCO and both security checks also passed.All 1,119 unit tests and TypeScript passed in pre-push at
e3ecb47.All 18 Bestie browser cases and all 30 autocomplete cases passed across Chromium and WebKit. All 16 layout/completion-layout cases and 14 design-system browser cases also passed.
Screenshot review found and fixed avatar overlap in short panels; regression coverage checks that the image stays above the transcript.
Local batch checks passed: 35 integration tests, frontend builds, lint/design checks, Rust formatting, and workspace Clippy. The broad browser run had one stale companion-copy assertion, repaired and verified by rerunning the complete affected files.
Fixed two test-ordering races found during validation: establish each asynchronous signer before releasing its gate, and wait for autocomplete retry options to render before keyboard navigation. No runtime changes, retries, skipped tests, or timeout increases.
Local native limitation: 8 of 9 native tests passed on this Mac. The real-login-shell probe is blocked by a managed security acknowledgement prompt. No shell policy or test timeout was changed. Hosted Rust and tool integration validates the native tests on Linux.
Model/hardware feel remains a manual check; fixture screenshots are not inference benchmarks.