Skip to content

fix: stabilize pay point of sale flow#658

Open
k9ert wants to merge 1 commit into
mainfrom
kn/pay-pos-stabilization
Open

fix: stabilize pay point of sale flow#658
k9ert wants to merge 1 commit into
mainfrom
kn/pay-pos-stabilization

Conversation

@k9ert

@k9ert k9ert commented Jun 30, 2026

Copy link
Copy Markdown

Split from #157 to keep the Pay POS route/test stabilization separate from the admin phone-rate-limit reset work.

Context

The POS flow had a route replacement loop risk because query params were compared by object identity. The Cypress test also depended on fixture account state that was not established inside the test.

Changes

  • Compare current POS query params by value before replacing the route.
  • Create and verify the POS Cypress username/default-wallet fixture before exercising the cash register flow.

Validation

  • buck2 test //apps/pay:lint
  • buck2 build //apps/pay:build-ci
  • Pay app CI passed on the split PR.
  • The failed SDL job was rerun because the log showed an external Rover plugin download timeout, not a code failure.
  • BATS passed after rerunning an unrelated onchain-send broadcast retry failure.

@github-actions github-actions Bot added the pay label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant