review: address jeffersonBastos feedback on PR #54 (BLEU-834 manifests)#56
Merged
brunota20 merged 1 commit intoJun 22, 2026
Conversation
Three threads from the internal review mirror of upstream nullislabs/shepherd PR #17: 1. ethflow-watcher/module.toml capabilities: move `chain` from required to optional. The comment on the original manifest already said the module does not call `chain` today; declaring it as required widened the grant for a capability the module does not exercise. Optional keeps "future-proofing" (BLEU-855 can use it without manifest churn) without violating least-privilege. 2. ethflow-watcher/module.toml subscription comment: soften the "identical on every chain" claim. cow-rs::ETH_FLOW_PRODUCTION is identical across chains today, but unlike ComposableCoW's CREATE2 address EthFlow has had multiple per-network and per-version deployments historically. Multi-chain config in M5 must re-check per `chain_id` instead of assuming the address carries. Address itself stays unchanged: 0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeC is verified against the live Sepolia deployment (event firing observed in the COW-1064 dry-run on 2026-06-18 + cow-rs canonical constant + multiple load-test runs). 3. README.md module manifest example: the documented `address` field said `0xC92E8bdf79f0507f65a392b0ab4667716BFE0110` labeled "ComposableCoW", but that is the GPv2VaultRelayer (per scripts/lib.sh). ComposableCoW is `0xfdaFc9d1902f4e0b84f65F49f244b32b31013b74`. Fixed the address; expanded the comment to clarify it is the canonical CREATE2 address (same on every supported chain). Stays on `feat/m2-module-manifests-bleu-834` as a stacked branch so upstream PR #17 + internal mirror PR #54 can see the fixes as a separate, atomic commit. AI assistance disclosure: drafted by Claude (Opus 4.7, 1M context).
lgahdl
added a commit
that referenced
this pull request
Jul 10, 2026
Review follow-ups - three of the six tests could not fail for the property they claimed to verify: - run() now returns its (blocks, chain_logs) dispatch tally (the same numbers the shutdown log line reports). The no-starvation test asserts both queued events were drained instead of merely observing that run() terminates on the shutdown timer - a broken or reordered select arm now leaves a count at 0 and fails. - New direct test: a reconnect task parked on a dropped receiver exits with TaskExit::ReceiverGone on its own, joined on the bare handle. The previous test claimed to verify this through TaskSet::shutdown, which aborts every handle before joining, so ReceiverGone was never exercised; its doc comment now states the abort-then-join contract it actually proves. - harness_shutdown_after_push_completes_cleanly raced shutdown against dispatch and accepted either outcome. Replaced with harness_shutdown_preserves_completed_dispatch: prove the dispatch completed, tear down, then re-read the log record after teardown. - The harness no-starvation test now queues both event kinds before awaiting either, so the biased select genuinely arbitrates two ready streams instead of replaying the two pre-existing sequential tests. - New harness_delivers_blocks_in_push_order: blocks 7,8,9 pushed back-to-back must surface in the module's log records in that order - issue #56's ordering guarantee, previously untested. - run()-level tests wrapped in tokio::time::timeout so a shutdown-path hang fails in 10 s instead of stalling the suite to the CI job limit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TfSsJPYDQ1GQGbnSVFxATx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked review-fix branch for the three actionable threads from jeffersonBastos on the internal mirror PR #54 (= upstream PR nullislabs#17).
Changes per thread
1.
modules/ethflow-watcher/module.tomlcapabilities (thread on line 17)Reviewer:
chainis required but the module does not call it today; declaring an unused capability widens the grant.Fix: move
chainfromrequiredtooptional. Keeps future-proofing (BLEU-855 can use it without manifest churn) while honouring least-privilege.2.
modules/ethflow-watcher/module.tomlsubscription comment (thread on line 34)Reviewer: the "identical on every chain" wording is too confident given EthFlow's multi-network / multi-version deployment history.
Fix: rewrite the comment to (a) cite the actual source (
cowprotocol/ethflowcontract/networks.prod.json), (b) flag the contrast with ComposableCoW's CREATE2-canonical address, (c) explicitly warn that M5 multi-chain config must re-check perchain_id. Address itself stays unchanged:0xbA3cB449bD2B4ADddBc894D8697F5170800EAdeCis verified against the live Sepolia deployment (COW-1064 dry-run on 2026-06-18 + cow-rs canonical constant + load-test runs all matched).3.
README.mdmodule manifest example (thread on line 107)Reviewer: the documented
addressis wrong -0xC92E8bdf...0110is GPv2VaultRelayer, not ComposableCoW.Fix: replace with the canonical ComposableCoW CREATE2 address
0xfdaFc9d1902f4e0b84f65F49f244b32b31013b74and expand the inline comment to call out that it is the same on every chain.Comment #3 from the same thread set
Confirmed positive (canonical CREATE2 ComposableCoW). No action.
Stack
review/m2-manifests-jefferson-pr54->feat/m2-module-manifests-bleu-834(PR #54 head; same head as upstream nullislabs#17).Once both PR #54 and #17 absorb this, the manifests branch carries the review fixes into upstream review without losing the original BLEU-834 commit's history.
Validation
grep "—"in my added linesAI assistance disclosure: drafted by Claude (Opus 4.7, 1M context).