Skip to content

Fixed tkinter and local imports - #93

Open
Sory-Noroc wants to merge 1 commit into
blavejr:masterfrom
Sory-Noroc:master
Open

Fixed tkinter and local imports#93
Sory-Noroc wants to merge 1 commit into
blavejr:masterfrom
Sory-Noroc:master

Conversation

@Sory-Noroc

Copy link
Copy Markdown

Hey!
I am a new contributor, also new to Git, so I would appreciate if you would accept me in this project, and perhaps guide me as I develop/contribute to the app. :)

@blavejr

blavejr commented Mar 13, 2021

Copy link
Copy Markdown
Owner

Hey @Sory-Noroc welcome to the crew. :)
I will take a look at your changes on Sunday evening and accept them if they are good, but I think they will be.
thank you for helping out.

@KokoseiJ

Copy link
Copy Markdown
Collaborator

First of all, Thank you for your contribution.

if sys.version_info >= (3,) works already well in Python2. I doubt replacing it to try statement is a good idea. If it didn't work before, please tell us.

other than that- everything looks good. blavejr will accept it as soon as he checks the code.

@blavejr

blavejr commented Mar 15, 2021

Copy link
Copy Markdown
Owner

I agree with @KokoseiJ, the try might not be the best solution unless there is another reason.

Comment thread organise_desktop/Clean.py
Frame.__init__(self, master)
self.pack()
self.create()
self.folders = [x for x in Extensions]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good initiative, but you would need to change all the folders variables to self.folder otherwise it will not use self.folder at all.

@Sory-Noroc

Sory-Noroc commented Mar 15, 2021 via email

Copy link
Copy Markdown
Author

Comment thread organise_desktop/Clean.py
import tkMessageBox

pwd = os.path.dirname(os.path.abspath(__file__))
Extensions = json.load(open(pwd+'/Extension.json', 'r'))

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably move these 2 into the class too as class constants

@blavejr

blavejr commented Mar 15, 2021

Copy link
Copy Markdown
Owner

You might be right but I was getting an ImportError with the previous version from that tkMessageBox Lun, 15 mar. 2021, 22:56 Remigius Kalimba Jr @.***> a scris:

I agree with @KokoseiJ https://github.com/KokoseiJ, the try might not be the best solution unless there is another reason. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHLJ4NHMQBGXMUGYMILVTTDZYA3ANCNFSM4ZDR2UCQ .

Hmmm are you running this on python3? because in that case we might be missing something

@Sory-Noroc

Sory-Noroc commented Mar 15, 2021 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants