Repository navigation
Pass non-plain object values (Date, Map, ...) through in change-case/keys - #368
Open
yfwmaniish wants to merge 1 commit into
Open
yfwmaniish wants to merge 1 commit into
yfwmaniish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Problem
change-case/keysrecurses into every value that istypeof === "object", including built-ins likeDate,Map,Set, andRegExp. For those it builds a shallow clone withObject.create(Object.getPrototypeOf(object))and copies own enumerable keys — but built-ins carry their state in internal slots, not enumerable properties, so the "clone" is a broken husk with the right prototype and none of the internals.For a
Datethis is easy to hit (from #356):out.createdAtisDate {}— a prototype-only object with no[[DateValue]]. The same breakage applies toMap,Set,RegExp, and any class instance that relies on internal slots.Fix
Only recurse into arrays and plain objects; pass any other object through unchanged as a value. Plain-object detection is a prototype check (
Object.prototypeornull), soObject.create(null)bags still get transformed, and nested plain objects/arrays are unaffected.Behavior
Object.create(null)Date/Map/Set/RegExpTests
Added a
keys.spec.tscase assertingDate,Map, andRegExpvalues are passed through by reference and remain functional (toISOString()works). Fullchange-casesuite passes (28 tests), typecheck and Prettier clean.