fix(feedgen): initialize pinned_post_uri in test configs#198
Open
Lawhacknifemi wants to merge 2 commits into
Open
fix(feedgen): initialize pinned_post_uri in test configs#198Lawhacknifemi wants to merge 2 commits into
Lawhacknifemi wants to merge 2 commits into
Conversation
Author
|
@rudyfraser Hey ruddy , do you mind reviewoing this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
E0063compiler errors in thersky-feedgentest suite.The
pinned_post_urifield was added to theFeedGenConfigstruct in commit 2209a00 to support pinned post rendering. However, the fiveFeedGenConfigstruct initializers inside the unit tests (located inrsky-feedgen/src/apis/mod.rs) were not updated to define this new field, causing compilation to fail.This PR initializes the
pinned_post_urifield with an empty string ("".to_string()) in all five test config initializations, restoring compilation capability while keeping the original test conditions intact.Related Issues
Fixes local test suite compilation failure.
Changes
Checklist