Skip to content

Add playlist creation from add dialog#486

Draft
daveliu wants to merge 1 commit into
blackcandy-org:masterfrom
daveliu:codex/dynamic-add-playlist
Draft

Add playlist creation from add dialog#486
daveliu wants to merge 1 commit into
blackcandy-org:masterfrom
daveliu:codex/dynamic-add-playlist

Conversation

@daveliu

@daveliu daveliu commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an inline create-playlist form to the Add to Playlist dialog.
  • Preserve the selected song_id when creating a new playlist from that dialog.
  • Create the playlist and add the selected song in one transaction, then redirect to the new playlist.

Closes #464

Validation

  • bin/rails test test/controllers/playlists_controller_test.rb:22 test/controllers/dialog/playlists_controller_test.rb:6
  • bundle exec rubocop app/controllers/playlists_controller.rb test/controllers/playlists_controller_test.rb test/controllers/dialog/playlists_controller_test.rb
  • bundle exec erb_lint app/views/dialog/playlists/index.html.erb

Note: the broader focused controller suite hit an unrelated missing test asset (application.css) in this disposable Docker test environment when rendering the playlist index.

@daveliu

daveliu commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Chrome verification for the Add to Playlist dialog on this branch:

  • Opened the Songs page in Google Chrome
  • Opened the Add to Playlist modal from the song list flow
  • Confirmed the new Create Playlist field is present
  • Confirmed the Create and Add submit button is present
  • Confirmed existing playlist targets still render below it

Chrome verification screenshot

@daveliu daveliu changed the title [codex] Add playlist creation from add dialog Add playlist creation from add dialog Jun 22, 2026
@aidewoode

Copy link
Copy Markdown
Member

@daveliu Thank you for your PR. because the redesign I am working on will have conflicts on your change. I will hold on this PR until my redesign is finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Add to playlist - Dynamic add

2 participants