Skip to content
This repository was archived by the owner on Sep 4, 2019. It is now read-only.

Fixed PR 343138 - Contact fields with Chinese characters are returned as...#660

Open
rwmtse wants to merge 1 commit into
blackberry:nextfrom
blackberry-webworks:fix-contacts-unicode
Open

Fixed PR 343138 - Contact fields with Chinese characters are returned as...#660
rwmtse wants to merge 1 commit into
blackberry:nextfrom
blackberry-webworks:fix-contacts-unicode

Conversation

@rwmtse

@rwmtse rwmtse commented May 25, 2013

Copy link
Copy Markdown
Contributor

... ?? when searching with PIM APIs
@bryanhiggins @erikjohnzon
I will port this to cordova-blackberry-plugins soon.

@jeffheifetz

Copy link
Copy Markdown
Contributor

If we were unescaping, don't we still need to do so?

@rwmtse

rwmtse commented May 28, 2013

Copy link
Copy Markdown
Contributor Author

@jeffheifetz I am not removing the unescaping, I just replaced those calls with decodeURIComponent(), which is used in other extensions. I don't know why this one used unescape()

@jeffheifetz

Copy link
Copy Markdown
Contributor

I know, but the issue is that escape will handle "'" characters. Should we perhaps be doing both?

@rwmtse

rwmtse commented May 30, 2013

Copy link
Copy Markdown
Contributor Author

@jeffheifetz Read this link about unescape() vs. decodeURIComponent()

@jeffheifetz

Copy link
Copy Markdown
Contributor

@rwmtse I have read the link and can tell you from personal experience that they handle different things. decodeURIComponent() will not handle ' characters while unescape() will. (There are other differences as well). Ultimately if you want ' characters encoded/decoded you need to do both.

@rwmtse

rwmtse commented May 31, 2013

Copy link
Copy Markdown
Contributor Author

@jeffheifetz Using both now

@rwmtse

rwmtse commented May 31, 2013

Copy link
Copy Markdown
Contributor Author

r+?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants